-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @astrojs/mdx to v3 #1846
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
🦋 Changeset detectedLatest commit: 6fe71de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
This reverts commit 2ecb227.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested a few scenarios locally and could not find any specific issue, this is looking like a pretty amazing update to me 🌟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Looking forward to the next release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this PR. Looking forward to this!
Given Astro 4.8 seems to break script hoisting MDX and this forces an upgrade to 4.8, we might need to hold off merging this until withastro/astro#11063 is fixed? |
I've sent withastro/astro#11084 that fixes it. |
Ensures users won’t hit withastro/astro#11063
Thank you for the quick fix @bluwy! 💖 |
* main: (45 commits) i18n(tr): add `showcase.mdx` (withastro#1896) [ci] format i18n(zh-cn): Update `authoring-content.md` (withastro#1901) [ci] format [ci] release (withastro#1897) [ci] format i18n(tr): update `authoring-content.md` (withastro#1887) Micro-optimization: clean up `<details>` CSS (withastro#1892) [ci] format i18n(tr): update `components.md` file (withastro#1889) [ci] format i18n(tr): add css-and-tailwind (withastro#1893) [ci] format [ci] release (withastro#1890) Adds custom styles for `<details>` and `<summary>` elements in Markdown content (withastro#1735) Update @astrojs/mdx to v3 (withastro#1846) [ci] format [ci] release (withastro#1869) Add BlueSky social icon (withastro#1871) [ci] format ...
Description
@astrojs/mdx
bundled with Starlight to the new v3 release, which comes with several performance improvementsoptimize
option to MDX for even faster builds.^4.8.0^4.8.6Some other small changes I needed to make:
Updated Vitest to 1.4.0 — there were some compatibility issues with the upgraded Vite and the older Vitest version we were using. (Did not update to latest Vitest as that was also causing another issue we can investigate later.)Superseded by Update Vitest to1.6.0
#1861Ignored some moreTurned out that was only happening with Vitest 1.6.0 — reverted..d.ts
files being generated during tests